ssh-key: p521 feature
#180
Merged
+177
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds initial integration with the `p521` crate, including support for converting public and private keys to `p521` keys, as well as signing and verifying NIST P-521 signatures. Note that there's a lot of redundancy/boilerplate repeated for `p256`, `p384`, and `p521` it would be nice to eventually DRY out, possibly using macros to write the impls.
tarcieri
force-pushed
the
ssh-key/p521
branch
from
6b8a0ac
to
93279ad
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial integration with the
p521crate, including support for converting public and private keys top521keys, as well as signing and verifying NIST P-521 signatures.Note that there's a lot of redundancy/boilerplate repeated for
p256,p384, andp521it would be nice to eventually DRY out, possibly using macros to write the impls.